[ http://issues.apache.org/jira/browse/DERBY-815?page=all ]
A B updated DERBY-815:
----------------------
Attachment: d815_regress.java
I was finally able to get a repro for this issue against Derby Client.
For what it's worth, there's one comment in your patch that looks suspicious,
namely, the last three lines of the following code block:
+ if (cp.drdaType != drdaType ||
+ cp.drdaLength != drdaLength) {
+ if (SanityManager.DEBUG) {
+ trace(ps+" param " +j+
+ " type: "+
+ drdaTypeName(cp.drdaType)+
+ "->"+drdaTypeName(drdaType)+
+ " length: "+
+ cp.drdaLength+"->"+drdaLength);
+ }
+ // Trust that this is OK...
+ cp.drdaType = drdaType;
+ cp.drdaLength = drdaLength;
When I turned tracing on and ran the repro, the output from the Sanity.DEBUG
block was printed, which perhaps means that the assignment is _not_ okay...?
To run the repro, start the server on port 1527, then run
> java d815_regress
Please let me know if that doesn't reproduce the problem for you. Note that,
for whatever reason, I had to do a full ant clobber and rebuild in order for
the repro to actually work...
> Prevent unneeded object creation and excessive decoding in parseSQLDTA_work()
> -----------------------------------------------------------------------------
>
> Key: DERBY-815
> URL: http://issues.apache.org/jira/browse/DERBY-815
> Project: Derby
> Type: Sub-task
> Components: Network Server, Performance
> Versions: 10.0.2.2, 10.1.1.0, 10.1.2.0, 10.1.1.1, 10.1.1.2, 10.1.2.1,
> 10.1.3.0, 10.1.2.2
> Reporter: Knut Anders Hatlen
> Assignee: Dyre Tjeldvoll
> Priority: Minor
> Fix For: 10.2.0.0
> Attachments: d815_regress.java, derby-815.diff, derby-815.stat,
> derbyall_report.txt
>
> Reported by Kathey Marsden in DERBY-212:
> In reviewing the Network Server Code and profiling there were several
> areas that showed potential for providing performance
> improvement. Functions that need optimizing to prevent unneeded object
> creation and excessive decoding: parseSQLDTA_work()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
