[ 
http://issues.apache.org/jira/browse/DERBY-856?page=comments#action_12365024 ] 

David Van Couvering commented on DERBY-856:
-------------------------------------------

Hi, Narayanan.  I took a quick look at this patch.  In general it looks quite 
good, except for one nit: the error message.

Currently it says 

"The resulting value is outside the range for the data type CLOB"

I know you are using an existing message, but since we're at it, it would be 
better if it said something a little more relevant to the end user, like:

"The resulting value is has a size of {0} which exceeds the maximum length of 
{1} for a Clob in Derby"

David

> modify setCharacterStreamInternal to take a long for the length, and perform 
> the > max int check in the method
> --------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-856
>          URL: http://issues.apache.org/jira/browse/DERBY-856
>      Project: Derby
>         Type: Improvement
>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: All Environments
>     Reporter: V.Narayanan
>     Assignee: V.Narayanan
>     Priority: Minor
>  Attachments: setCharacterStreamInternal.diff, 
> setCharacterStreamInternal.stat, setCharacterStreamInternal_1.diff, 
> setCharacterStreamInternal_2.diff, setCharacterStreamInternal_2.stat
>
> A similar change to setBinaryStreamInternal is being handled as part of 
> DERBY-599. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to