Hi,
I just want to throw in my 2 cents:
- cleanup code needs to be separate from 'real' code changes (I've been bitten by that one myself a couple of times).
- If code is being cleaned up in a particular file, I think the same cleanup should probably happen (or at least contemplated) in at least the 10.1 branch and trunk, to ensure back/forward porting remains doable.
Myrna
On 2/6/06, Rick Hillegas <[EMAIL PROTECTED]> wrote:
Hi Kev,
You might want to take a look at the following wiki page, which tries to
summarize issues for new contributors:
http://wiki.apache.org/db-derby/DerbyContributorChecklist.
You'll notice that the community hasn't agreed on a single coding
standard, although that wiki page links to two models used by Derby
developers..
Thanks in advance for your contributions!
Regards,
-Rick
Kev Jackson wrote:
> Hi all,
>
> I've been looking at contributing to derby for a couple of weeks now,
> mainly small code cleanups etc just to get my feet wet.
>
> In the code I've noticed that the style is very different from what
> I'm used to from open source Java (and indeed commercial Java).
> if (condition)
> _expression_;
>
> instead of
>
> if (condition) {
> _expression_;
> }
>
> public class Whatever
> {
>
> }
>
> instead of
>
> public class Whatever {
>
> }
>
> Is there a resource that details the code style that should be
> followed for patch submissions? I'm willing to contribute as I'd like
> to learn a bit about how databases work under the hood, but I can't
> stand the current code style and I'd like to know if this is an agreed
> upon convention, or a legacy of the various owners of the codebase up
> to now.
>
> Thanks
> Kev
