[ 
http://issues.apache.org/jira/browse/DERBY-796?page=comments#action_12366380 ] 

Daniel John Debrunner commented on DERBY-796:
---------------------------------------------

The embedded changes look good.

Is there any reason for the changes in the TestConnection.java class, such as 
database name from mydb to mydb1?
And is there any good reason for this class, why don't these tests get the 
connections the standard way, used by all
other tests in the harness?

I see this pattern in the tests for failed exceptions:

+            catch(IOException ioe) {
+                System.out.println("Input output exception occurred" + ioe);
+            }
+            catch(SQLException sqle) {
+                System.out.println("SQLException occurred" + sqle);
+            }

I guess it's not critical but this approach to displaying errors is a real pain 
when you actually hit a failure.

Just printing what you print means that on a failure, I have to find which line 
was causing the error,
not easy if one uses the same text like "SQLException occurred", modify  that 
code to print the stack trace,
modify the code to print the SQLException chain, and then re-run the test.

Printing the stack trace, and for SQLExceptions the complete nested chain and 
their stack traces can often
mean spotting what the problem is instantly.  

> jdbc 4.0 specific Blob and Clob method support
> ----------------------------------------------
>
>          Key: DERBY-796
>          URL: http://issues.apache.org/jira/browse/DERBY-796
>      Project: Derby
>         Type: New Feature
>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: jdbc 4.0 on all platforms
>     Reporter: V.Narayanan
>     Assignee: V.Narayanan
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: ClientFramework_Explanation.txt, lob.diff, lob_1.diff, 
> lob_2.diff, lob_3.diff, lob_4.diff, lob_4.stat
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to