[ 
http://issues.apache.org/jira/browse/DERBY-983?page=comments#action_12366418 ] 

David Van Couvering commented on DERBY-983:
-------------------------------------------

Hi, Anurag.  Thanks for this patch.  

Can you explain the motivation for adding a new class SQLExceptionFactory?  
Can't you just use the existing model, something like:

  throw new SqlException(null, SQLState.NOT_IMPLEMENTED, 
"getRowId(int)").getSQLException();

If you need a shorthand, then why not put the shorthand method in the existing 
SqlException class?  e.g. 

  throw SqlException.notImplemented().getSQLException();

Is there a specific reason to create a separate class?

Thanks,

David

> NetClient JDBC (40) using engine classes
> ----------------------------------------
>
>          Key: DERBY-983
>          URL: http://issues.apache.org/jira/browse/DERBY-983
>      Project: Derby
>         Type: Bug
>   Components: Network Client
>  Environment: all
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>  Attachments: derby-983.diff
>
> network client has refrence of 
>  org.apache.derby.impl.jdbc.Util.notImplemented ()
> this will cause class not found exception as this class is not part of client 
> jar 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to