[ http://issues.apache.org/jira/browse/DERBY-938?page=all ]
Dyre Tjeldvoll updated DERBY-938:
---------------------------------
Attachment: derby-938.v2.diff
derby-938.v2.stat
derbyall_report.v2.txt
Attached a new patch (derby-934.v2.*) that removes the getContext()
optimization as suggested by the reviewers. A couple of things to note:
- The modification was not completely independent of the rest of the patch, so
there were some additional changes, e.g. the traversal of the StatementContexts.
- I have not changed ContextIds from Strings to ints, for reasons explained in
(http://article.gmane.org/gmane.comp.apache.db.derby.devel/14273)
- Even without this patch ContextManager depends on the language module in
cleanupOnError(Throwable), which references
org.apache.derby.iapi.reference.ContextId.LANG_CONNECTION (line 254), and
org.apache.derby.iapi.reference.ContextId.LANG_STATEMENT (line 271). So the
only added dependency introduced by the first version of the patch was that on
ExecutionContexts.CONTEXT_ID, which could easily have been moved to
org.apache.derby.iapi.reference.ContextId as suggested in
http://article.gmane.org/gmane.comp.apache.db.derby.devel/14273
Anyway, more work is needed to make ContextManager completely independent, as
intended.
> ContextManager needs to be optimized
> ------------------------------------
>
> Key: DERBY-938
> URL: http://issues.apache.org/jira/browse/DERBY-938
> Project: Derby
> Type: Improvement
> Components: Performance
> Reporter: Dyre Tjeldvoll
> Assignee: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-938.diff, derby-938.html, derby-938.v2.diff,
> derby-938.v2.stat, derbyall_report.v2.txt, get.html, get.v2.html
>
> ContextManagers are used extensively, particularly to get access to
> ExcutionContexts and StatementContexts. Optimizing this access should improve
> overall performance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
