[ 
http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12366971 ] 

Bryan Pendleton commented on DERBY-515:
---------------------------------------

I checked derby-515-patch2-v1.diff.

I thought it was a little odd that the diff contains changes to the two master 
files which are to be deleted. The status file is clear about the files which 
are to be deleted and the file which is to be added, so maybe I'm just not 
practiced at reading diffs which contain deleted files.

The changes to NetworkServerControlImpl.java look good to me, and the patch 
applied cleanly (modulo my confusion about the deleted files) and 
derbynet/NSinSameJVM.java passed for me with both client frameworks. So it 
looks good to me.


> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
>          Key: DERBY-515
>          URL: http://issues.apache.org/jira/browse/DERBY-515
>      Project: Derby
>         Type: Improvement
>   Components: Network Server
>     Versions: 10.1.2.0, 10.2.0.0
>     Reporter: Kathey Marsden
>     Assignee: Deepa Remesh
>      Fix For: 10.2.0.0
>  Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, 
> derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to 
> the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server  were 
> recorded in the derby.log, so there would not be a need to check t the  
> console output.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to