[ http://issues.apache.org/jira/browse/DERBY-942?page=comments#action_12367722 ]
Rick Hillegas commented on DERBY-942: ------------------------------------- Hi Anurag, Thanks for the preliminary peek at this patch. Looks good. I like the way you handled the optional inclusion of the JDBC4-specific classes in the jar file. I recommend adding class and method comments to the test classes so that reviewers will know what these tests are supposed to stress. Thanks for the explanation of why you disabled the SecurityManager and for commenting the property file accordingly. When we do commit this patch, let's leave the JIRA open to remind us to re-enable the SecurityManager after mustang fixes its bug. Cheers-Rick > Add JDBC4 Ease of Development Support > ------------------------------------- > > Key: DERBY-942 > URL: http://issues.apache.org/jira/browse/DERBY-942 > Project: Derby > Type: New Feature > Components: JDBC > Reporter: Rick Hillegas > Assignee: Anurag Shekhar > Fix For: 10.2.0.0 > Attachments: derby-942.diff > > As described in the JDBC 4 spec, sections 20.1, 20.2, and 3.1. > The Ease of Development extensions provide a way to create tabular DataSets > from queries and tuple signatures. The jdk ships with a factory for creating > these DataSets, which is a class which implements the QueryObjectGenerator > interface. A database can write its own custom QueryObjectGenerator, or just > ship with the default, jdk-shipped version. For this task, we will simply > wire the default jdk-shipped factory into the appropriate methods: > Connection.createQueryObject() and DataSource.createQueryObject(). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
