[
http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12368085 ]
John H. Embretsen commented on DERBY-819:
-----------------------------------------
I just wanted to point out some minor comment typos, in case you want to fix
them in the next revision:
Index: java/engine/org/apache/derby/impl/jdbc/SQLExceptionFactory.java:
+public class SQLExceptionFactory {
+ /**
+ * method to create construct SQLException
+ * version specific drivers can overload this method to create
+ * version specific exceptions
+ */
Remove either "create" or "construct" in first sentence. Add a period (.) after
first sentence (remember, HTML version of javadoc will not necessarily include
a line break here).
Index: java/engine/org/apache/derby/impl/jdbc/Util.java:
/**
- This looks up the message and sqlstate values and generates
+ This looks up the message and sqlstate values and and calls
+ out the SQLExceptionFactory method to generate
the appropriate exception off of them.
*/
Remove duplicate "and". Remove "out" in "calls out?
+ /**
+ * this method is called to replace the exception facotry to be
+ * used to generate the SQLException or the subclass
+ */
Typo: "facotry" should be "factory".
Index:
java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/TestJDBC40Exception_app.properties:
+#This test is tests JDBC40 (JDK 1.6) SQLException subclasses
+#ignore the earlier jvm
Strange wording. Maybe "This test is testing JDBC 4.0 SQLException subclasses
available from JDK1.6. Ignoring earlier JVM versions." would be better?
> Provide JDBC4 SQLException subclasses support in Embedded driver
> ----------------------------------------------------------------
>
> Key: DERBY-819
> URL: http://issues.apache.org/jira/browse/DERBY-819
> Project: Derby
> Type: Sub-task
> Components: JDBC
> Environment: all
> Reporter: Anurag Shekhar
> Assignee: Anurag Shekhar
> Priority: Minor
> Attachments: .derby-819_2.stat, derby-819-onlyforreview.diff,
> derby-819.diff, derby-819_2.diff, derby-819_3.diff, derby-819_4.diff,
> derby-819_5.diff, stat.out
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
