i did not look at the patch, just make sure you are not throwing an SQLException on close(), should be a no-op

Knut Anders Hatlen (JIRA) wrote:
     [ http://issues.apache.org/jira/browse/DERBY-1060?page=all ]

Knut Anders Hatlen updated DERBY-1060:
--------------------------------------

    Fix Version: 10.2.0.0
     Other Info: [Patch available]

Patch available. Please review. Thanks!

  
ResultSet methods should throw exception when the ResultSet is closed
---------------------------------------------------------------------

         Key: DERBY-1060
         URL: http://issues.apache.org/jira/browse/DERBY-1060
     Project: Derby
        Type: Bug
  Components: JDBC, Network Client, Newcomer
    Versions: 10.2.0.0
    Reporter: Knut Anders Hatlen
    Assignee: Knut Anders Hatlen
    Priority: Minor
     Fix For: 10.2.0.0
 Attachments: derby1060-v1.diff, derby1060-v1.stat, derbyall_report.txt

The JDBC 4 spec says:
  Once a ResultSet has been closed, any attempt to access any of its
  methods with the exception of the isClosed method will result in a
  SQLException being thrown.
This is not always the case in Derby, and the behaviour is not the
same on the client driver and the embedded driver.
The following ResultSet methods do not throw an exception when the
result set is closed:
  Client driver:
    clearWarnings()
    close()
    getMetaData()
    getStatement()
    getWarnings()
  Embedded driver:
    close()
    getConcurrency()
    getRow()
    getStatement()
    getType()
    rowDeleted()
    rowInserted()
    rowUpdated()
    setFetchDirection()
    getFetchDirection()
    setFetchSize()
    getFetchSize()
    

  

Reply via email to