this sounds great to me.

Andreas Korneliussen (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-1067?page=comments#action_12369228 ]
Andreas Korneliussen commented on DERBY-1067:
---------------------------------------------

I have been thinking about the testing of this feature. I have already 
submitted a set of tests in HoldabilityTest.junit, which tests this feature as 
soon as SUR (DERBY-690) gets reviewed and committed. The test is a pure jdbc 
test.

However, maybe it would be cleaner if the related store code from DERBY-690 
gets moved into this issue ? Then I could write pure store unit tests.

DERBY-690 extends the ScanController with a method called 
positionAtRowLocation(..).  It is in this method one would need to check the 
rowLocationsInvalidated flag.  A store unit test could i.e do the following:

1. Open a scan
2. scan forward, and remeber some RowLocations
3. reposition the scan using positionAtRowLocation(..).

The holdability case would be:
1. Open a scan
2. scan forward, and remeber some RowLocations
3. Commit the transaction
4. Run compress on the container
5. assert that positionAtRowLocation(..) returns false
This would also make the DERBY-690 patch even cleaner.


support holdable Scrollable Updatable Resultsets
------------------------------------------------

        Key: DERBY-1067
        URL: http://issues.apache.org/jira/browse/DERBY-1067
    Project: Derby
       Type: Sub-task
   Reporter: Andreas Korneliussen
   Assignee: Andreas Korneliussen
Attachments: DERBY-1067.diff, DERBY-1067.stat





Reply via email to