[
http://issues.apache.org/jira/browse/DERBY-1093?page=comments#action_12370533 ]
A B commented on DERBY-1093:
----------------------------
My own personal preference would be for option #3. ODBCMetadataGenerator.java
has the following:
// Types of changes that are possible. There are three
// types that we handle here:
//
// 1. Column rename:
// Rename a column to have an ODBC-specified name.
// For ex. change "SCALE" to "DECIMAL_DIGITS"
// 2. Type and/or value change:
// Cast a column to an OBDC-specified type. At time
// of writing, this was just for casting INTs to
// SMALLINTs; OR modify an existing JDBC value
// to match the ODBC specification.
// 3. Additional column(s):
// Add a new, ODBC-specified column to an existing
// result set.
private final byte COL_RENAME_CHANGE = 0x01;
private final byte TYPE_VALUE_CHANGE = 0x02;
private final byte ADD_COLUMN_CHANGE = 0x04;
So it seems like the most "complete" change would be to add a #4 for removing
non-ODBC columns. As you said, that would be more work, but I also think it
would be most helpful as it would provide a common basis for generating
ODBC-compliant queries in the future.
That said, Derby is a scratch-your-own-itch world so if you feel like going
with approach #1 and it doesn't break existing ODBC functionality, that's your
choice. However, I am a bit concerned by this comment:
> And with that option it should be easy enough for someone familiar with ODBC
> to clean up metadata.properties later.
What kind of "cleanup" are we talking about here?
> Make DatabaseMetaData.getProcedures() JDBC4 compliant
> -----------------------------------------------------
>
> Key: DERBY-1093
> URL: http://issues.apache.org/jira/browse/DERBY-1093
> Project: Derby
> Type: Sub-task
> Components: JDBC, Newcomer
> Versions: 10.2.0.0
> Reporter: Dyre Tjeldvoll
> Assignee: Dyre Tjeldvoll
> Priority: Minor
> Fix For: 10.2.0.0
>
> JDBC 4.0 requires that the result set returned from getProcedures must
> contain a new column SPECIFIC_NAME"and that the result set must be ordered by
> PROCEDURE_SCHEM, PROCEDURE_NAME and SPECIFIC_ NAME.
> The SYSALIASES table already has a column called SPECIFICNAME, so it should
> only be necessary to modify the query in metadata.properties.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
