[ http://issues.apache.org/jira/browse/DERBY-919?page=comments#action_12370710 ]
Andreas Korneliussen commented on DERBY-919: -------------------------------------------- Review of BaseJUnitTestClasses-v1.tar: This patch looks good. I downloaded the files you submitted, and checked how it would work to change SURBaseTest to extend BaseJDBCTest. This worked very well with. I removed the getConnection() method in SURBaseTest., so that the class would use the getConnection() method from BaseJDBCTest. Then I successfully ran the tests that extend SURBaseTest as type .junit, both in the embedded framework and in the DerbyNetClient framework. Minor comments: 1. In BaseJDBCTestCase class initializer: I think you could print the stack trace for the exception. 2. In TestConfiguration: isVerbose is always set to false. 3. I would like methods to log stuff and print stack traces. You do not have to supply them here, I can add them later since that is my itch. > improve pattern for setting up junit tests > ------------------------------------------ > > Key: DERBY-919 > URL: http://issues.apache.org/jira/browse/DERBY-919 > Project: Derby > Type: Sub-task > Components: Test > Environment: All > Reporter: Andreas Korneliussen > Assignee: Kristian Waagan > Attachments: BaseJUnitTestClasses-v1.tar, BasicDerbyJUnitTest.html, > BasicDerbyJUnitTest.java, BasicDerbyJUnitTestTest.java, JDBCClient.java, > TestConfiguration.java > > The current junit tests cannot be run directly from the java.ui.textrunner by > i.e using: > java junit.textui.TestRunner > org.apache.derbyTesting.functionTests.tests.junitTests.lang.BooleanTest > .E > Time: 0.008 > There was 1 error: > 1) > testBoolean(org.apache.derbyTesting.functionTests.tests.junitTests.lang.BooleanTest)java.lang.NullPointerException > at > org.apache.derbyTesting.functionTests.util.DerbyJUnitTest.faultInDriver(DerbyJUnitTest.java:317) > at > org.apache.derbyTesting.functionTests.util.DerbyJUnitTest.getConnection(DerbyJUnitTest.java:345) > at > org.apache.derbyTesting.functionTests.util.DerbyJUnitTest.getConnection(DerbyJUnitTest.java:335) > at > org.apache.derbyTesting.functionTests.tests.junitTests.lang.BooleanTest.testBoolean(BooleanTest.java:136) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > FAILURES!!! > Tests run: 1, Failures: 0, Errors: 1 > The reason is that the tests needs to have some fixture being set up before > the test can run, and that this is currently supported by calling a bunch of > static methods in the correct order to initialize some static members of > DerbyJUnitTest. > The proposed alternative is that the added fixture is set up in the suite() > method, which is used by JUnit to get the Test object to be run. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
