Rick Hillegas (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12370883 ]
Rick Hillegas commented on DERBY-1097:
--------------------------------------
Hi Kristian,
1) I'm afraid I'm missing some context here. It looks like you have some idea
of how these JUnit tests for jdbc4 can be wired into a suite. This will be
particularly useful as developers add more JUnit tests for jdbc4. Could you
create that suite and provide instructions for how to run it under all the
supported environments?
As is already stated, this test can be run from any suite by simply
adding it with the .junit extension. I do not want to add it to the
existing jdbc4 suite, because this suite is only run under
DerbyNetClient (and tests embedded behavior at the same time - ie. it
runs tests for two different frameworks under one framework).
Generally, we can follow the existing scheme by adding the names of the
tests we want to run in files under functionTests/suites (with the
.junit extension, not .java), or we can create a more complex suite()
method in a test file. Since the latter solution breaks the way things
are currently done, the former is preferred.
I was a bit confused when looking at the suites. I initially thought a
suite would be run in all frameworks, except from those explicitly
excluded. It seems a suite is only run under the specified framework.
Am I correct in assuming the class must then be added to two different
suites?
One for embedded and one for DerbyNetClient? (does run under DerbyNet)
2) I also don't understand the motivation behind checking in a test which fails
in an expected environment.
I expected the bug to be fixed shortly, and it already is!
Besides, the test is not included in any suite yet, so it would not be
run and cause problems for anyone.
3) When you resubmit the patch, it will really help the reviewer if you package
up the whole submission as a diff-style patch. Thanks.
I will.
New patch will be uploaded after addressing David's comments.
--
Kristian
Add tests for Statement.isClosed()
----------------------------------
Key: DERBY-1097
URL: http://issues.apache.org/jira/browse/DERBY-1097
Project: Derby
Type: Sub-task
Components: Test
Versions: 10.2.0.0
Environment: JDBC4 / JDK 1.6
Reporter: Kristian Waagan
Assignee: Kristian Waagan
Attachments: StatementTest.java, StatementTest.java-v1,
StatementTestSetup.java, StatementTestSetup.java-v1
Add tests for Statement.isClosed() (implemented as part of DERBY-953).
The tests are already written, but because of some "confusion" and diverging
paths regarding how to get connections when running JUnit tests, they are held back.
