[ http://issues.apache.org/jira/browse/DERBY-993?page=comments#action_12371062 ]
Andreas Korneliussen commented on DERBY-993: -------------------------------------------- Review of DERBY-993-skipwfoundation.diff : Patch looks good, however I hope the following could be addressed: 1. In SURBaseTest you have removed the getConnection() method. However getNewConnection() has been rewritten to use TestUtil instread of calling getConnection().. I think getNewConnection() could be left unchanged, so that it uses the BaseJDBCTestCase's getConnection() method. 2. BaseTestCase: here methods for printing debug is added, which is good. I would like the _DEBUG flag removed from the class, and instead use CONFIG.verbose(). The _DEBUG flag does not seem to be initialized anywhere. The HoldabilityTest fails due to a bug in Derby. It should be enabled as part of fixing the bug in DERBY-1058. > junitTests cannot be run with J2ME > ---------------------------------- > > Key: DERBY-993 > URL: http://issues.apache.org/jira/browse/DERBY-993 > Project: Derby > Type: Test > Components: Test > Versions: 10.2.0.0 > Environment: using J2ME jvm > Reporter: Myrna van Lunteren > Assignee: Myrna van Lunteren > Priority: Minor > Attachments: DERBY-993-skipwfoundation.diff, DERBY-993-skipwfoundation.stat, > DERBY-993_2006_03_18.diff > > The test suite junitTests/LangSuite, and the .junit tests > jdbcapi/SURTest.java and jdbcapi/SURQueryMixTest.java fail with J2ME, because > it uses java.sql.Driver. > There should be a way to use java.sql.DataSource instead of the Driver > mechanism. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
