[ http://issues.apache.org/jira/browse/DERBY-974?page=comments#action_12371365 ]
Deepa Remesh commented on DERBY-974: ------------------------------------ Thanks Michael for reporting and working on this issue. I took a look at PropetiesTest.java and it demonstrates the problem. For your question about how to create patches, please take a look at http://db.apache.org/derby/derby_comm.html. It is recommended to include a regression test when submiiting patches. Please go through http://wiki.apache.org/db-derby/DerbyCommitHowTo You can also look at this link http://wiki.apache.org/db-derby/ForNewDevelopers, which has pointers to the links I just mentioned along with some more information to get started with Derby development. Hope this helps. > ClientDriver can lose some connection properties > ------------------------------------------------ > > Key: DERBY-974 > URL: http://issues.apache.org/jira/browse/DERBY-974 > Project: Derby > Type: Bug > Components: Network Client > Versions: 10.1.2.1, 10.1.2.2 > Environment: Linux, Sun JRE 1.5 > Reporter: Michael Hackett > Priority: Minor > Attachments: ClientDriver.java-diff, PropertiesTest.java > > Internally, the ClientDriver class's appendDatabaseAttributes() method uses > keys() on the connection properties to get a list of the property names. > However, this misses any properties in the default set. The correct method > for a Properties object is propertyNames(). This will return the same type of > object as keys(), but will include all properties. > (It is unfortunate that Sun chose to make Properties a subclass of Hashtable, > instead of giving Properties a Hashtable, as the former exposes too much > implementation.) > The fix is to simply replace calls to keys() on all Property objects to use > propertyNames(). A quick search revealed that this is not the only place in > the code base where this is done, so a more thorough scan should be made. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
