[ http://issues.apache.org/jira/browse/DERBY-953?page=all ]

Kristian Waagan updated DERBY-953:
----------------------------------

    Attachment: DERBY-953-3a.diff

'DERBY-953-3a.diff' is a patch implementing pretty much what David suggested. I 
made some corrections, and I also had to add a try-catch block to the 
'checkExecStatusNoException'-method, because we are using the 
Connection-interface there, not the EmbedConnection implementation. It is not 
quite clear to me if we can get another Connection-implementation there, but I 
have assumed so. If the connection is *always* an EmbedConnection, we could 
cast.

Other comments:
1) The patch has some white-space changes. The file contains a mix of tabs and 
spaces, and I chose to use spaces for the patch.
2) The patch also has some Javadoc fixes.
3) My StatementTest passes (embedded and DerbyNetClient, JCC excluded due to 
missing JDBC4 support).
4) I ran derbyall, but made some minor changes afterwards. The first one 
passed, the second run is ongoing. I will report if errors occur.

Patch can be reviewed and committed.

> Add miscellaneous Statement methods introduced by JDBC 4
> --------------------------------------------------------
>
>          Key: DERBY-953
>          URL: http://issues.apache.org/jira/browse/DERBY-953
>      Project: Derby
>         Type: New Feature
>   Components: JDBC
>     Reporter: Rick Hillegas
>     Assignee: Kristian Waagan
>      Fix For: 10.2.0.0
>  Attachments: DERBY-953-1a.diff, DERBY-953-1a.stat, DERBY-953-2a.diff, 
> DERBY-953-3a.diff
>
> As described in the JDBC 4 spec, sections 13.1 and 3.1.
> This adds support for new Statement methods added by JDBC4 and not addressed 
> by other JIRAs: isClosed() and getResultSetHoldability().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to