[ http://issues.apache.org/jira/browse/DERBY-1155?page=comments#action_12372130 ]
Daniel John Debrunner commented on DERBY-1155: ---------------------------------------------- I'll commit this, with a couple of minor changes. Fix the copyright for the new class to have the correct dates, all of its code is old code thus should retain the original copyright dates Change EmbedXAResource to be non-public, don't think there is any reason for the class to be public. > Separate XAResource from EmbedXAConnection > ------------------------------------------ > > Key: DERBY-1155 > URL: http://issues.apache.org/jira/browse/DERBY-1155 > Project: Derby > Type: Improvement > Components: JDBC > Versions: 10.2.0.0 > Environment: all > Reporter: Anurag Shekhar > Assignee: Anurag Shekhar > Attachments: derby-1155.diff > > jdbc4.0 introduces two new methods in javax.sql.PooledConnection. Due to this > a new implementation of PooledConnection and XAConnection for jdbc4.0 is > required. According to current hierarchy XAConnection extends from > PooledConnection. Going by similar hierarchy for new classes > PooledConnection40 will extend from PooledConnection and XAConnection40 will > be extending from PooledConnection40. > This structure forces to replicate all the methods of XAConnection to be > present in XAConnection40 too. In the current implementation > EmbedXAConnection itself is XAResource. This will cause to replicate all the > XAResource methods to be present in XAConnection40. > Separating these two implementation will save replication of lots of methods. > See the comments on jira issue 1137 for some more discussion about this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
