Thanks, Kristian. I have already made similar changes in my revision.
I am still working on the patch -- I need to revert the changes to the
embedded client as it appears SQL States really can't change as it
breaks compatibility. I am instead (trying to) log a bug with JIRA --
although it is down again for me.
David
Kristian Waagan (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-1149?page=all ]
Kristian Waagan updated DERBY-1149:
-----------------------------------
Attachment: DERBY-1149-3a-StatementTestFailure.diff
'DERBY-1149-3a-StatementTestFailure.diff' changes the identifier "25000.S.1" to
"25001", and removes references to SQLState in StatementTest.java. The rest of this patch
is David's, and nothing of it is changed. StatementTest passes under both embedded and
DerbyNetClient.
'jdbc40/StatementTest.junit' fails under DerbyNetClient
-------------------------------------------------------
Key: DERBY-1149
URL: http://issues.apache.org/jira/browse/DERBY-1149
Project: Derby
Type: Test
Components: Regression Test Failure, Test
Versions: 10.2.0.0
Environment: JDK 1.6 (b76 used, believed to apply to all)
Reporter: Kristian Waagan
Assignee: David Van Couvering
Attachments: DERBY-1149-2a-StatementTestFailure.diff,
DERBY-1149-3a-StatementTestFailure.diff, DERBY-1149-StatementTestFaiure.diff
One of the tests in jdbc40/StatementTest.junit fails with the following message:
"Attempt to shutdown framework: DerbyNetClient
0 add
....F.
There was 1 failure:
1)
testIsClosedWhenClosingConnectionInInvalidState(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)junit.framework.ComparisonFailure:
Unexpected exception thrown: Cannot close a connection while a global transaction is still
active. expected:<java.sql.Connection.close() requested while a transaction is in
progress on the connection.The transaction remains active, and the connection cannot be
closed...> but was:<Cannot close a connection while a global transaction is still
active...>
FAILURES!!!
Tests run: 5, Failures: 1, Errors: 0
Test Failed.
*** End: StatementTest jdk1.6.0-beta2 DerbyNetClient 2006-03-24 12:53:22 ***"
The reason is that the exception message text has been changed. This comparison
is only done when running DerbyNetClient, because SQLState was not implemented
there.
The checkin that caused the error:
"Author: davidvc
Date: Thu Mar 23 16:55:44 2006
New Revision: 388309
URL: http://svn.apache.org/viewcvs?rev=388309&view=rev
Log:
DERBY-839 (Partial). Internationalize Connection.java. Also upgraded
the "i18n lint" test to be a little more intelligent, and to not exit
on the first failure.
Passes derbynetclientmats. All changes are client-specific so derbyall
was not run."
A
