[
http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12372394 ]
Kristian Waagan commented on DERBY-1149:
----------------------------------------
The following part of the patch does not make sense to me:
+ if ( ! expectedState.equals(sqle.getSQLState()) )
+ {
+ fail("Unexpected SQL State encountered; got "
+ + sqle.getSQLState() + ", expected " + expectedState +
+ ". Unexpected exception message is " + sqle.getMessage());
+
+ throw sqle;
What fail() does, is that it throws an AssertionFailedException.
I think you must either just throw the exception, or use the fail-method.
Also, any specific reason why you don't tick off the button for granting a
license to ASF?
> 'jdbc40/StatementTest.junit' fails under DerbyNetClient
> -------------------------------------------------------
>
> Key: DERBY-1149
> URL: http://issues.apache.org/jira/browse/DERBY-1149
> Project: Derby
> Type: Test
> Components: Regression Test Failure, Test
> Versions: 10.2.0.0
> Environment: JDK 1.6 (b76 used, believed to apply to all)
> Reporter: Kristian Waagan
> Assignee: David Van Couvering
> Attachments: DERBY-1149-2a-StatementTestFailure.diff,
> DERBY-1149-3a-StatementTestFailure.diff,
> DERBY-1149-4a-StatementTestFailure.diff, DERBY-1149-StatementTestFaiure.diff
>
> One of the tests in jdbc40/StatementTest.junit fails with the following
> message:
> "Attempt to shutdown framework: DerbyNetClient
> 0 add
> > ....F.
> > There was 1 failure:
> > 1)
> > testIsClosedWhenClosingConnectionInInvalidState(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)junit.framework.ComparisonFailure:
> > Unexpected exception thrown: Cannot close a connection while a global
> > transaction is still active. expected:<java.sql.Connection.close()
> > requested while a transaction is in progress on the connection.The
> > transaction remains active, and the connection cannot be closed...> but
> > was:<Cannot close a connection while a global transaction is still
> > active...>
> > FAILURES!!!
> > Tests run: 5, Failures: 1, Errors: 0
> Test Failed.
> *** End: StatementTest jdk1.6.0-beta2 DerbyNetClient 2006-03-24 12:53:22
> ***"
> The reason is that the exception message text has been changed. This
> comparison is only done when running DerbyNetClient, because SQLState was not
> implemented there.
> The checkin that caused the error:
> "Author: davidvc
> Date: Thu Mar 23 16:55:44 2006
> New Revision: 388309
> URL: http://svn.apache.org/viewcvs?rev=388309&view=rev
> Log:
> DERBY-839 (Partial). Internationalize Connection.java. Also upgraded
> the "i18n lint" test to be a little more intelligent, and to not exit
> on the first failure.
> Passes derbynetclientmats. All changes are client-specific so derbyall
> was not run."
> A
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
