[ http://issues.apache.org/jira/browse/DERBY-775?page=comments#action_12373647 ]
Øystein Grøvlen commented on DERBY-775: --------------------------------------- I have had a look at the test changes in this patch. I realize most of my comments are general comments to SUR-tests rather than particular to this patch. Hence, I do not think it needs to be resolved before this patch is checked in. 8. SURBaseTest - assertWarning(): Why is the SQLState not tested for DerbyNetClientFramework()? Would it not be more general to skip the test if SQLState was null? 9. SURQueryMixTest - I do not think the Javadoc for testNavigation is up-to-date. It says that it requires that the resultset is position before the first row, but starts with a call to afterLast(). It is a void function, but Javadoc says it returns a map. - It seems like this test is based on making an update, read the updated row into a map and use that for comparison when you renavigate to that row. This assumes that what you read after an update reflects the updates just made. Do you have a test that tests that the intended update is actually reflected? 10. HoldabilityTest - Why do you not check warnings for isDerbyNetClientFramework? 11. SURTest - Why are some of the tests on forward-only result sets and not on scrollable? 12. updatableResultSet - I see from the master files that different SQLStates are used in the embedded versus in the client. E.g., 01J02 vs. 01X02, 24000 vs. XCL07/XCL08/XCL16. Is that the way it is supposed to be? > Network client: Add support for scrollable, updatable, insensitive result sets > ------------------------------------------------------------------------------ > > Key: DERBY-775 > URL: http://issues.apache.org/jira/browse/DERBY-775 > Project: Derby > Type: New Feature > Components: Network Client, JDBC > Versions: 10.2.0.0 > Reporter: Dag H. Wanvik > Assignee: Dag H. Wanvik > Priority: Minor > Attachments: 775-writeup.txt, derby-775-1.diff, derby-775-1.stat, > derby-775-2.diff, derby-775-2.stat, derby-775-3.diff, derby-775-3.stat > > This is a part of the DERBY-690 effort. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
