Bryan Pendleton <[EMAIL PROTECTED]> writes:

> It looks to me as though both DERBY-822 and DERBY-1196 are changing
> the behavior of the Network Server w.r.t. SQLExceptions that may
> occur during the OPNQRY.
>
> DERBY-1196 removed some code that closed the statement if
> a SQLException occurred during OPNQRY.
>
> DERBY-822 is adding some code that closes the statement if a
> SQLException occurs during OPNQRY.

Thanks for catching this, Bryan!

It seems like cleanUpAndCloseStatement() introduced by DERBY-822 has a
misleading name. The name was chosen based on a comment in
DRDAConnThread.processCommands():

    // if we got a SQLException we need to clean up and
    // close the statement Beetle 4758

However, the code closes the statement's current result set, not the
statement itself. I will rename the method and update the comment.

-- 
Knut Anders

Reply via email to