[ http://issues.apache.org/jira/browse/DERBY-514?page=comments#action_12374551 ]
Andrew McIntyre commented on DERBY-514: --------------------------------------- Committed derby-514-patch3-v2.diff with revision 394157. Two minor comments: it would be nice if the properties file that contains the derbyTesting.jar.path property did not update on every recompile. You should be able to use Ant's <uptodate> task to determine if the file has already been modified and skip modifying it again. Also, I noticed that you removed the assignment of the first two arguments in UpgradeTester.java without shifting the other indices, but is this class meant to be run standalone anymore? It doesn't appear to be the case anymore, and maybe the main method could be removed. > Integrate upgrade tests into test suite > --------------------------------------- > > Key: DERBY-514 > URL: http://issues.apache.org/jira/browse/DERBY-514 > Project: Derby > Type: Test > Components: Test > Versions: 10.1.2.0, 10.2.0.0 > Reporter: Kathey Marsden > Assignee: Deepa Remesh > Fix For: 10.2.0.0 > Attachments: derby-514-buildfiles-v1.diff, derby-514-buildfiles-v1.status, > derby-514-patch1-v1.diff, derby-514-patch1-v1.status, > derby-514-patch2-runtest-v1.diff, derby-514-patch2-runtest-v1.status, > derby-514-patch3-v1.diff, derby-514-patch3-v1.status, > derby-514-patch3-v2.diff, derby-514-patch3-v2.status, > derby-514-patch4-sed.diff, derby-514-patch4-sed.status > > Currently there are no upgrade tests in the derbyAll suite. > The upgrade tests java/testing/org/apache/derbyTesting are run by script and > require that the version to be tested by specified on the command line so > that the classpath can be changed. > # runphases old_major old_minor old_engine new_engine > # > # e.g. > # > # runphases 10 0 c:/derby/10.0.2.1/lib c:/derby/trunk/jars/sane > Perhaps this script can be rewritten in Java using class loaders and > previous Derby verssions such as 10.0 and 10.1 be checked in so that this > testing can be incorporated into the derbyAll test suite. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
