[ http://issues.apache.org/jira/browse/DERBY-901?page=all ]
Sunitha Kambhampati updated DERBY-901:
--------------------------------------
Attachment: for_10.1_derby901.p1.diff.txt
for_10.1_derby901.p1.stat.txt
Thanks Kathey for commiting my phase 1 patch. I am attaching following files
for_10.1_derby901.p1.diff.txt and for_10.1_derby901.p1.stat.txt. for 10.1
codeline.
The changes are the same as the Derby901.p1.diff.txt attached earlier.
-------------------
DERBY-901 (partial)
Remove use of String(byte[]) constructors in network server leading to
non-portable behaviour
This fixes
- SQLERRMC_TOKEN_DELIMITER, SQLERRMC_MESSAGE_DELIMITER and the corresponding
usage of it in SystemProcedures to not use the default string constructors that
are non portable.
-----------------------
I ran derbyall on linux/ibm142 and no new failures.
If this looks ok, can this be committed. Thanks.
> Remove use of String(byte[]) constructors in network server leading to
> non-portable behaviour
> ---------------------------------------------------------------------------------------------
>
> Key: DERBY-901
> URL: http://issues.apache.org/jira/browse/DERBY-901
> Project: Derby
> Type: Bug
> Components: Network Server
> Reporter: Daniel John Debrunner
> Assignee: Sunitha Kambhampati
> Attachments: Derby901.p1.diff.txt, Derby901.p1.stat.txt, TestEnc.java,
> for_10.1_derby901.p1.diff.txt, for_10.1_derby901.p1.stat.txt
>
> These constructors use the Java default platform encoding to convert the
> bytes to a String, this typically leads to bugs on platforms with different
> encodings.
> Replace with code using fixed conversion, or alternative mechanisms.
> If the call is required its use should be commented as to why it is required.
> org.apache.derby.impl.drda.DRDAConnThread
> I generated this list using the Java search in eclipse for references to the
> constructors
> String(byte[])
> String(byte[],int,int) - no occurences found in java/drda
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
