Investigate how to avoid storing query options in both DRDAStatement and
DRDAResultSet
--------------------------------------------------------------------------------------
Key: DERBY-1225
URL: http://issues.apache.org/jira/browse/DERBY-1225
Project: Derby
Type: Improvement
Components: Network Server
Versions: 10.2.0.0
Reporter: Knut Anders Hatlen
Priority: Minor
In the review of DERBY-822, it was commented that some configurable
options were stored in both DRDAStatement and DRDAResultSet when it
was enough to have one copy in DRDAResultSet.
>From DRDAStatement.java:
// Query options sent on EXCSQLSTT
// These the default for ResultSets created for this statement.
// These can be overriden by OPNQRY or CNTQRY,
protected int nbrrow; // number of fetch or insert
rows
protected int qryrowset; // Query row set
protected int blksize; // Query block size
protected int maxblkext; // Maximum number of
extra blocks
protected int outovropt; // Output Override
option
protected boolean qryrfrtbl; // Query refresh answer set
table
private int qryprctyp = CodePoint.QRYBLKCTL_DEFAULT; // Protocol type
All of these fields are also present in DRDAResultSet. The fields in
DRDAStatement are only used when DRDAStatement.execute() is
initializing its DRDAResultSets. Since DRDAStatement.execute() is
called right after the fields in DRDAStatement are set (either on an
OPNQRY or an EXCSQLSTT), it should be possible to pass the values
directly to the DRDAResultSet without having the fields duplicated in
DRDAStatement.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
