Re: [jira] Commented: (DERBY-1176) Stored prepared statements in the SYSIBM schema are not updated on upgrade

[Oystein Grovlen - Sun Norway]

Dag H. Wanvik (JIRA) wrote:

Minor nit-picks:

- EmbedDatabaseMetaData.java

  * Code readability:

if ((removeSYSIBMonly && isSYSIBM) || !removeSYSIBMonly) {

     <do something>
  }

  might be more readable as:

  if (removeSYSIBMonly && !isSYSIBM) {
       // do nothing
  } else {
       <do something>
  }

Another and IMHO even more readable alternative is:

if (isSYSIBM || !removeSYSIBMonly) {
      <do something>
}


--
Øystein