[ http://issues.apache.org/jira/browse/DERBY-1180?page=comments#action_12375555 ]
Dyre Tjeldvoll commented on DERBY-1180: --------------------------------------- I have looked at the patch, and I think it looks good, but I have a coule of observations: - EmbedBlob.getBinaryStream() seems very well documented, but free() in the same class is not. - In EmbedClob neither method is documented. I'm not convinced that it is all that important to document these implementations if the methods are well documented in the interface. At least I don't think there is much point in duplicating information found in the interface... - createBlob() and createClob() have been defined in BrokeredConnection40, but they are not java 1.5(6) specific, so couldn't they have been placed in BrokeredConnection instead? I don't think it really matters, but for other similar classes we have tried to keep as much as possible in the base class. > Add vacuous implementations of missing JDBC4 methods > ---------------------------------------------------- > > Key: DERBY-1180 > URL: http://issues.apache.org/jira/browse/DERBY-1180 > Project: Derby > Type: New Feature > Components: JDBC > Versions: 10.2.0.0 > Reporter: Rick Hillegas > Assignee: Kristian Waagan > Attachments: bug1180_1.diff, bug1180_embeddedStarter.diff, > derby-1180-1a-embedded.diff, derby-1180-1a-embedded.stat > > If you run the VerifySignatures test, you will see a lot of JDBC4 methods > which don't appear in our implementation yet. We need to add vacuous > implementations for these methods which raise > SQLFeatureNotSupportedExceptions. Most of these methods won't need any more > attention because they refer to features (like xml and national strings) > which we don't support. We will open additional JIRAs for the methods which > need non-vacuous implementations. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
