[ 
http://issues.apache.org/jira/browse/DERBY-7?page=comments#action_12377852 ] 

Myrna van Lunteren commented on DERBY-7:
----------------------------------------

Hi Berndt,

I happened to spot the following in your check-in for revision 399657 for the 
test jdbcapi/resultset.java:

+                               } catch(SQLException ex){
+                                       if (ex.getSQLState().equals("22005")) {
+                                               if (s.getBytes (i) != null)
+                row.append(new String(s.getBytes(i)));
+                                               else
+                row.append(s.getBytes(i));
+                                       } else throw ex; 
+                               }

I think what has happened here is that you applied original patch of DERBY-7 to 
10.1. 

However, the test resultset.java has since had some work done on it, and I'm 
specifically concerned that you may have missed the changes I worked on for 
DERBY-903, which were committed with revision 378337 and 379643. 

This eliminates the use of the constructor 'new String(bytes[]), which is 
non-portable...It constructs a string by decoding the bytes using the default 
platform charset. This can lead to encoding related problems.  For this case, 
you should probably use the constructor that takes in the encoding. ie new 
String(byte[], String charsetname). 

Can you please rework this section of resultset.java to not use an 
encoding-safe mechanism? 
Just compare with the current 10.2 resultset.java...

Thx,
Myrna

> Bug in NULLIF Function
> ----------------------
>
>          Key: DERBY-7
>          URL: http://issues.apache.org/jira/browse/DERBY-7
>      Project: Derby
>         Type: Bug

>   Components: SQL
>     Versions: 10.0.2.0
>     Reporter: Tulika Agrawal
>     Assignee: Mamta A. Satoor
>     Priority: Minor
>      Fix For: 10.2.0.0, 10.1.3.0
>  Attachments: Derby-7.txt, Derby7NullIf061005svndiff.txt, derby-nullif.patch, 
> derby7Nullif080205svndiff.txt
>
> Reporting for Christian d'Heureuse, filed on derby-dev list.
> The NULLIF built-in function of Cloudscape 10.0.1.0 beta seems to accept
> only string values.
> Examples:
>  values nullif('a','b');
>  --> OK
>  values nullif(1,2);
>  --> Error message: "ERROR 42X89: Types 'CHAR' and
>      'INTEGER' are not type compatible. (Neither type
>      is assignable to the other type.)"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to