[ 
http://issues.apache.org/jira/browse/DERBY-1291?page=comments#action_12379120 ] 

Daniel John Debrunner commented on DERBY-1291:
----------------------------------------------

Rick said "That leaves Dan's serious objection that we are changing the 
contract of public classes. "

I don't think I said I had a "serious objection", I merely asked if this change 
in contract had been discussed.

I actually think that this falls into the "Exceptions" category from 
http://wiki.apache.org/db-derby/ForwardCompatibility,
it seems unlikely that code was using the DataSource api on Derby's XA and 
ConnectionPolling apis. Though we should
allow community members who work application server people time to follow up on 
this issue and see if any application
servers are dependent on the existing behaviour. Maybe post to derby-user 
indicating we are thinking of not having Derby's
XA and ConnectionPooling DataSource implementations implement the base 
DataSource api any more.

I do think though that upgrade testing recently brought into the mainline by 
Deepa should be enhanced to test:
   - serializing Derby''s data source implementations in 10.1 and seeing it 
unserializes with 10.2
      (maybe into a BLOB column)

  - making a Reference object out of Derby''s data source implementations in 
10.1 and making it into
     an object with 10.2. (if this type of tetsing makes sense for References')

>  Modify DataSource classes of Embedded Driver to seperate DataSource , 
> XADataSource and ConnectionPooledDataSource
> ------------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1291
>          URL: http://issues.apache.org/jira/browse/DERBY-1291
>      Project: Derby
>         Type: Improvement

>   Components: JDBC
>     Versions: 10.2.0.0
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>  Attachments: derby-1291.diff
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to