[ 
http://issues.apache.org/jira/browse/DERBY-892?page=comments#action_12412433 ] 

Andrew McIntyre commented on DERBY-892:
---------------------------------------

Wow, thanks for cooking up a great patch from my half-baked idea. This looks 
good, I've gone ahead and committed what you have to the trunk with revision 
407642, as I think it's a very good improvement

Couple of minor things:

- a property to replace the standard policy file completely would be nice. e.g. 
setting the property derbyTesting.replacePolicyFile=true would not copy the 
standard policy file just the test-specific one. Need to think about where and 
how to set that property for a single test. In the _app.properties? If so, need 
to think about how we will load the _app.properties and check for the property 
before we've actually run the test.

- document the new functionality and property in java/testing/README.htm

Please let me know if you can followup with a patch for those, otherwise I'll 
take care of it. Leaving this issue open until then.

> add mechanism for specifying policy file for individual function tests
> ----------------------------------------------------------------------
>
>          Key: DERBY-892
>          URL: http://issues.apache.org/jira/browse/DERBY-892
>      Project: Derby
>         Type: Bug

>   Components: Test
>     Versions: 10.2.0.0
>     Reporter: Myrna van Lunteren
>     Priority: Minor
>  Attachments: DERBY-892_20060514.diff, DERBY-892_20060514.stat, 
> derby-892_pre.diff
>
> It would be nice to be able to specify a test-specific policy file.
> This should get handled similar to existing properties, i.e. get specified in 
> a test_app.properties file (or, for a suite, in the suite.properties file).  
> The file should then be copied into the correct place.
> Note, that the 'old' functionTests harness (as opposed to junit tests) 
> includes a check for a property called 'serverPolicyFile' (in 
> harness/jvm.java). The name is a left over from when the policy file was only 
> used for/by network server, and should be renamed - derbyTestPolicyFile, for 
> instance. It is not used anywhere at present, and not specific to network 
> server. It would be nice if this could be expanded, or, if not used, removed.
> The default policy file used is the derby_tests.policy file under 
> functionTests/util.
> Also, currently, the property can only be used with RunTest - for further 
> traction, it should probably get passed on through RunSuite/RunList.
> Once confirmed to be working, the property should get documented in 
> <trunk>/java/testing/README.htm.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to