[
http://issues.apache.org/jira/browse/DERBY-1323?page=comments#action_12412784 ]
Fernanda Pizzorno commented on DERBY-1323:
------------------------------------------
All of my comments have been addressed in the DERBY-1323-2.diff.
The following changes seem unnecessary to me:
[...]
+ checkForClosedResultSet();
+ checkPositionedOnPlainRow();
+
boolean rowInserted = false;
- checkForClosedResultSet();
[...]
- boolean rowDeleted = (resultSetType_ ==
ResultSet.TYPE_SCROLL_INSENSITIVE) ?
- cursor_.getIsUpdateDeleteHole() :
- false;
+ boolean rowDeleted =
+ (resultSetType_ == ResultSet.TYPE_SCROLL_INSENSITIVE) ?
+ cursor_.getIsUpdateDeleteHole() : false;
[...]
I have seen comments against cosmetic changes before, but I am not sure we have
a policy against it.
> Detectability methods rowUpdated, rowInserted, rowDeleted can be called from
> illegal states in both clients
> -----------------------------------------------------------------------------------------------------------
>
> Key: DERBY-1323
> URL: http://issues.apache.org/jira/browse/DERBY-1323
> Project: Derby
> Type: Bug
> Components: JDBC, Network Client
> Versions: 10.2.0.0
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Priority: Minor
> Fix For: 10.2.0.0
> Attachments: DERBY-1323-1.diff, DERBY-1323-1.stat, DERBY-1323-2.diff,
> DERBY-1323-2.stat, Main.java
>
> Please see enclosed repro.
> These detectability methods fail to check that they can be called in
> some states. In the repro, calls are allowed while on insert row and
> when after last row. These should both fail. Both clients have the
> same problem. All three detectability methods have the same problem.
> (repro only shows it for a subset of the cases).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
