[ http://issues.apache.org/jira/browse/DERBY-1401?page=comments#action_12416180 ]
Tomohito Nakayama commented on DERBY-1401: ------------------------------------------ Committed ... Sending java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/Stream.java Transmitting file data . Committed revision 414199. > TestDataReader class in jdbcapi/Stream.java creates test data of which length > is not equals to value passed as length of test data. > ----------------------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-1401 > URL: http://issues.apache.org/jira/browse/DERBY-1401 > Project: Derby > Type: Bug > Components: Test > Reporter: Tomohito Nakayama > Assignee: Tomohito Nakayama > Attachments: DERBY-1401.patch > > In the work of DERBY-1301, I found this issue. > Seeing the code, next part in > org.apache.derbyTesting.functionTests.tests.jdbcapi.Stream.TestDataReader had > problem. > public int read( char[] cbuf, > int off, > int len ){ > > if(wroteLength >= total) > return -1; > > int i; > for(i = off ; > i < off + len && > wroteLength <= total ; > i++, wroteLength ++){ > > cbuf[i] = (char) (wroteLength % 0x10000L); > > } > return i - off; > } > Problem exists in next part... > wroteLength <= total > Because an evaluation of this expression is true when wroteLength equals > total, > test data is created beyond max length passed in total. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
