[ http://issues.apache.org/jira/browse/DERBY-1421?page=comments#action_12417988 ]
Andreas Korneliussen commented on DERBY-1421: --------------------------------------------- The patch looks good, however I have one issue which should be discussed/clarified: The patch makes use of an impl class (import org.apache.derby.impl.store.raw.data.RememberBytesInputStream) . I have not seen any other classes in the package org.apache.derby.iapi.types, make use of impl classes, so I am not sure if it breaks some design-rule in derby. In this case, it could probably be ok, since we are not exposing the impl class to the client, only using it in the implementation of a class. Another question is if we could avoid the cloning of the column somehow or if it is possible to use a shallow clone? As far as I can tell, the current cloning will do an inmemory copy of all data in the blob column, and if it is a 1GB blob, I think it will cause an OutOfMemory error. > ResultSet.updateBinaryStream fails when the result type is > TYPE_SCROLL_INSENSITIVE > ---------------------------------------------------------------------------------- > > Key: DERBY-1421 > URL: http://issues.apache.org/jira/browse/DERBY-1421 > Project: Derby > Type: Bug > Components: JDBC > Versions: 10.2.0.0 > Reporter: V.Narayanan > Assignee: Fernanda Pizzorno > Attachments: TestUpdateBinaryStream.java, derby-1421.diff, derby-1421.stat > > Attaching test program for the above bug. The program however works fine when > the ResultSetType is TYPE_FORWARD_ONLY. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
