[ http://issues.apache.org/jira/browse/DERBY-1474?page=all ]

Knut Anders Hatlen updated DERBY-1474:
--------------------------------------

    Attachment: derby-1474-1c.diff

I have reviewed the patch. The methods look very useful. I found one issue: 
assertEquals(Blob,Blob) has assertNull() on b1/b2 where the assert should be on 
is1/is2. Attached is an updated patch with that one fixed. Also, I fixed a 
spelling error in a comment and made the methods static. I will commit the new 
patch. Thank you, Kristian.

> Add assertEquals overloads for Blob and Clob
> --------------------------------------------
>
>          Key: DERBY-1474
>          URL: http://issues.apache.org/jira/browse/DERBY-1474
>      Project: Derby
>         Type: Sub-task

>   Components: Test
>     Versions: 10.2.0.0, 10.3.0.0
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: derby-1474-1a.diff, derby-1474-1a.stat, derby-1474-1b.diff, 
> derby-1474-1c.diff
>
> Add assertEquals(Blob,Blob) and assertEquals(Clob,Clob) to BaseJDBCTestCase.
> The naming follows the JUnit scheme, and the methods throws an 
> AssertionFailedError if the objects passed in are not equal.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to