[
http://issues.apache.org/jira/browse/DERBY-1272?page=comments#action_12419798 ]
Kathey Marsden commented on DERBY-1272:
---------------------------------------
Thanks Andrew for this great addition it will surely save many round trips
trying to get accurate sysinfo information.
I applied the pre3 patch and noticed the following:
1) After ant clobber, I built and got:
compile_types:
[javac] Compiling 1 source file to C:\p4\marsden_patch\classes
[javac]
C:\p4\marsden_patch\opensource\java\engine\org\apache\derby\impl\services\monitor\BaseMonitor.java:1949:
package org.apache.derby.tools does not exist
[javac]
org.apache.derby.tools.sysinfo.getInfo(systemStreams.stream().getPrintWriter());
[javac] ^
[javac]
C:\p4\marsden_patch\opensource\java\engine\org\apache\derby\impl\services\monitor\BaseMonitor.java:1951:
package org.apache.derby.tools does not exist
[javac]
org.apache.derby.tools.sysinfo.getInfo(getTempWriter());
[javac] ^
[javac] 2 errors
BUILD FAILED
2)
I forced the build and tried the patch with
derby.stream.error.logSeverityLevel=0 and the sysinfo in the derby.log seemed
to work great. I put it in one of the test derby.properties files to make sure
it ran ok with security manager and that worked ok too. It would be good to
have this turned on for one of the tests just to make sure security manager
issues don't creep in.
3)
I also tried it without the property and sysinfo still printed to the log,
which is really fine by me as it will save that initial round trip of setting
the property, but I don't know how others feel about it.
4) Just a minor nit I think it would be good if the sysinfo printed after the
boot message but as it is fine by me too.
Thanks again
Kathey
> Change sysinfo to print to error log (derby.log) on boot of derby if
> derby.stream.error.logSeverityLevel=0
> -----------------------------------------------------------------------------------------------------------
>
> Key: DERBY-1272
> URL: http://issues.apache.org/jira/browse/DERBY-1272
> Project: Derby
> Type: Improvement
> Components: Tools
> Versions: 10.2.0.0, 10.1.2.1, 10.1.3.0
> Reporter: Kathey Marsden
> Priority: Minor
> Attachments: derby-1272-pre.diff, derby-1272-pre2.diff, derby-1272-pre3.diff
>
> It is often very difficult to collect correct sysinfo output from user
> environments because sysinfo run from the commandline does not have the same
> classpath as the jvm that started Derby or Derby was loaded with a custom
> classloader.
> It would be very helpful in assisting users in diagnosing their issues if
> sysinfo dumped to the error log if derby.stream.error.logSeverityLevel=0 or
> even by default.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
