[
http://issues.apache.org/jira/browse/DERBY-1274?page=comments#action_12420844 ]
John H. Embretsen commented on DERBY-1274:
------------------------------------------
I have taken a look at the patch derby-1274v3.diff, and I think it looks good.
I found two minor typos in ShutDownDBWhenNSShutsDownTest.java:
- class level JavaDoc: "when started form the command line" should be "when
started from the command line".
- first comment inside testDatabasesShutDownWhenNSShutdown() method:
"Check that the database will be shut down when the server is start shut
down." I think the word "start" should be removed here.
I do not know of a very clean and easy way of starting the Network Server from
the command line from inside the test itself, without potentially losing some
important property or setting that the harness usually sets. The
harness.NetServer.java class might be helpful. Does anyone else have any ideas?
In the mean time, I think the way it is done in v3.diff is good enough.
> Network Server does not shutdown the databases it has booted when started and
> shutdown from the command line
> ------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-1274
> URL: http://issues.apache.org/jira/browse/DERBY-1274
> Project: Derby
> Type: Bug
> Components: Network Server
> Versions: 10.2.0.0, 10.1.2.3
> Reporter: Kathey Marsden
> Assignee: Fernanda Pizzorno
> Attachments: derby-1274.diff, derby-1274.stat, derby-1274v2.diff,
> derby-1274v3.diff, derby-1274v3.stat
>
> If network server is started and shutdown from the comand line t does not
> shutdown the database. This can is evidenced by the fact that the db.lck
> file remains after the following steps.
> java org.apache.derby.drda.NetworkServerControl start &
> <some database access>
> java org.apache.derby.drda.NetworkServerControl shutdown
> There is much discussion about the correct behavior of NetworkServer in this
> regard related to embedded server scenarios in DERBY-51, but it seems clear
> in this case the databases should be shutdown.
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
