[ http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12421542 ] Kristian Waagan commented on DERBY-982: ---------------------------------------
Hi Andrew, I reviewed the version 4 patch. Looks good to me, but I have one minor comment on the JUnit test. Although not too important for this test, it would be nice to have the constructor that takes a String argument. This makes it possible to select/run specific test methods from the/a suite method. Also, according to the JUnit documentation, the noarg constructor is there only to support serialization (which we don't require). Thanks, > sysinfo api does not provide genus name for client > -------------------------------------------------- > > Key: DERBY-982 > URL: http://issues.apache.org/jira/browse/DERBY-982 > Project: Derby > Issue Type: Bug > Components: Tools > Affects Versions: 10.1.2.1 > Reporter: Kathey Marsden > Assigned To: Andrew McIntyre > Fix For: 10.2.0.0 > > Attachments: derby-982-v4.diff, derby-982.diff, derby-982_v2.diff, > derby-982_v3.diff > > > The sysinfo api does not provide access to the genus name for client to allow > applications to retrieve information from sysinfo about the client > information. > http://db.apache.org/derby/javadoc/publishedapi/org/apache/derby/tools/sysinfo.html > Note: Currently ProductGenusNames has a genus name for network server but > network server is closely tied to the engine so should always have the same > version. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
