[ http://issues.apache.org/jira/browse/DERBY-694?page=comments#action_12422005 ] Deepa Remesh commented on DERBY-694: ------------------------------------
I went through this patch and have couple of small comments: * The change in StatementReply.readOpenQuery method to catch SQLExceptions and call one of the completeAbnormalUnitOfWork methods may not be okay in all cases. I think this is a general catch block and there could be SQLExceptions which are not because of a ABNUOWRM. So it may not be okay to call completeAbnormalUnitOfWork methods here. I think it may be better to move these calls to case where we receive ABNUOWRM. * In the new method NetConnectionReply.parseAbnormalEndUow(StatementCallbackInterface statement), the parameter 'statement' is not being used anywhere. > Statement exceptions cause all the connection's result sets to be closed with > the client driver > ----------------------------------------------------------------------------------------------- > > Key: DERBY-694 > URL: http://issues.apache.org/jira/browse/DERBY-694 > Project: Derby > Issue Type: Bug > Components: Network Client > Affects Versions: 10.1.1.1 > Reporter: Oyvind Bakksjo > Assigned To: V.Narayanan > Priority: Minor > Attachments: DERBY-694.html, DERBY-694_upload_v1.diff, > DERBY-694_upload_v1.stat, StatementRollbackTest.java > > > Scenario: > Autocommit off. Have two prepared statements, calling executeQuery() on both, > giving me two result sets. Can fetch data from both with next(). If one > statement gets an exception (say, caused by a division by zero), not only > this statement's result set is closed, but also the other open resultset. > This happens with the client driver, whereas in embedded mode, the other > result set is unaffected by the exception in the first result set (as it > should be). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
