[ http://issues.apache.org/jira/browse/DERBY-1555?page=comments#action_12422523 ] Daniel John Debrunner commented on DERBY-1555: ----------------------------------------------
Looking at this more the basic class structure is good, TestConfiguration as a stand-alone class, though the use of a static CONFIG variable has inflitrated a lot of tests. The pattern here http://www.devx.com/Java/Article/28119/1954?pf=true suggests using a ThreadLocal to pass context state around in JUnit tests, in this case it would be the TestConfiguration object. A new class BaseJDBCTestSetup extends TestSetup would also bring value, as most of the test decorators will be performing JDBC work. > API for configuration information in Derby's JUnit tests should through > instance methods of the base classes, not static methods and static fields > -------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-1555 > URL: http://issues.apache.org/jira/browse/DERBY-1555 > Project: Derby > Issue Type: Improvement > Components: Test > Reporter: Daniel John Debrunner > Assigned To: Daniel John Debrunner > > The heavy use of static state information in the existing Derby (non-Junit) > harness was a major mistake, it should not be repeated in the Junit model. > It should be changed before too many tests are written. > A static configuration will limit the ability for the tests to be flexible > and have different instances running with different configurations, > a instance based scheme will be more flexible. > This change will just change the api, the current implementation of a single > static configuration will remain but be hidden within the base-classes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
