[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ]
Daniel John Debrunner updated DERBY-1521:
-----------------------------------------
Derby Info: (was: [Patch Available])
Patch Committed revision 425846.
Two issues to be addressed though:
1) The code that calls testGrantRevokeNotSupported() is a little confusing:
+ case PH_SOFT_UPGRADE:
+ case PH_POST_SOFT_UPGRADE:
+ case PH_HARD_UPGRADE:
+ if(grantRevokeNotSupported)
+ passed = testGrantRevokeNotSupported(s, phase);
+
It would be good if this code continued to test correctly once this class
supports the next generation of upgrade.
So i think testGrantRevokeNotSupported would be always called, and pass in
grantRevokeNotSupported, then
check the sql state for the exception based upon grantRevokeNotSupported and
the phase.
2) Should REVOKE be tested in the testGrantRevokeNotSupported()? (given the
name of the method and we want to ensure REVOKE fails as well)
> Upgrade test needs to be enhanced to test grant revoke
> ------------------------------------------------------
>
> Key: DERBY-1521
> URL: http://issues.apache.org/jira/browse/DERBY-1521
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.2.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Deepa Remesh
> Fix For: 10.2.0.0
>
> Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status
>
>
> Grant Revoke is one of the features targeted for 10.2 Release. The upgrade
> test should be modified to test this feature with various upgrade scenarios
> to make sure everything works fine.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
