[ http://issues.apache.org/jira/browse/DERBY-815?page=comments#action_12424411 ] Kathey Marsden commented on DERBY-815: --------------------------------------
My review comment about hiding CliParam and handling of clearing parameters etc from DRDAConnThread is my only comment for now on this patch. I do not really have my head around all the cases and handling for parameter setting and clearing etc, so look forward to hearing review comments from others on the patch to understand better. My feeble mind might also be able to sort it out better once this change is made. Can we uncheck patch available or would you like more comments on this version? Also I wanted to mention that if you have higher urgency items for 10.2, don't feel compelled to jump on changing this right away. It could easily go into the maintenance branch after releas. I just picked it up as my patch for the week. Thanks Kathey > Prevent unneeded object creation and excessive decoding in parseSQLDTA_work() > ----------------------------------------------------------------------------- > > Key: DERBY-815 > URL: http://issues.apache.org/jira/browse/DERBY-815 > Project: Derby > Issue Type: Sub-task > Components: Network Server, Performance > Affects Versions: 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, > 10.1.3.0, 10.1.2.2, 10.0.2.2 > Reporter: Knut Anders Hatlen > Assigned To: Dyre Tjeldvoll > Priority: Minor > Fix For: 10.2.0.0 > > Attachments: d815_regress.diff, d815_regress.java, derby-815.diff, > derby-815.html, derby-815.v3.diff, derby-815.v3.html, derby-815.v3.stat, > derby-815.v4.diff, derby-815.v4.stat, derby-815_2.diff, > derbyall_report.v4.txt, derbyall_report_with_jdk1.4.v3.txt > > > Reported by Kathey Marsden in DERBY-212: > In reviewing the Network Server Code and profiling there were several > areas that showed potential for providing performance > improvement. Functions that need optimizing to prevent unneeded object > creation and excessive decoding: parseSQLDTA_work() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
