[ http://issues.apache.org/jira/browse/DERBY-1630?page=all ]
Andrew McIntyre updated DERBY-1630:
-----------------------------------
Attachment: derby-1630-v1.diff
Attaching a patch for this issue that replaces the call to
org.apache.derby.impl.jdbc.Util by throwing a new SQLException generated via
org.apache.derby.client.am.SqlException. The patch passed the
jdbc4/TestConnectionMethods test.
Please review the patch and let me know if you see any problems. I thought of
making this a SQLNonTransientException, but I wasn't sure if the
subclassification was necessary here.
Because this is blocking DERBY-1424, I would like to get this committed soon.
If there are no objections, I will commit this patch some time tomorrow, or a
reviewer could commit it in the interim if they feel it is acceptable.
> NetConnection40 references an engine class, org.apache.derby.impl.jdbc.Util
> ---------------------------------------------------------------------------
>
> Key: DERBY-1630
> URL: http://issues.apache.org/jira/browse/DERBY-1630
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.2.0.0
> Reporter: Andrew McIntyre
> Priority: Critical
> Fix For: 10.2.0.0
>
> Attachments: derby-1630-v1.diff
>
>
> NetConnection40.java contains this:
> ...
> import org.apache.derby.impl.jdbc.Util;
> ...
> public boolean isValid(int timeout) throws SQLException {
> // Validate that the timeout has a legal value
> if (timeout < 0) {
> throw Util.generateCsSQLException(SQLState.INVALID_API_PARAMETER,
> new Integer(timeout), "timeout",
> "java.sql.Connection.isValid");
> }
> ...
> This was added as part of DERBY-1090. This should be changed to use the
> client's method of throwing exceptions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
