[ 
http://issues.apache.org/jira/browse/DERBY-1643?page=comments#action_12425913 ] 
            
Daniel John Debrunner commented on DERBY-1643:
----------------------------------------------

I committed the patch but believe there should be a follow up. The new constant 
defined for the revoke invalidation is REVOKE_EXECUTE_PRIVILEGE, but I think 
it's factored in the wrong dimension. I think the behaviour being implemented 
is revoke restrict, and thus the constant should be: REVOKE_PRIVILEGE_RESTRICT.

Probably good to change this early rather than having some REVOKE constants 
meaning cascade and some restrict but no consistent naming.

I would have made a simple name change in Eclipse, but the comments around 
REVOKE_EXECUTE_PRIVILEGE wouldn't apply to the new name so it's a little more 
involved. Also with the REVOKE_PRIVILEGE_RESTRICT the descriptors could be 
modified to throw the exception even if today they don't support routines (eg. 
constraints) would make the code "self-healing" when check constraints support 
function calls.

> As per the functional spec attached to DERBY-1330, a "revoke execute ... 
> restrict" should fail if there are dependent objects on the execute privilege
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1643
>                 URL: http://issues.apache.org/jira/browse/DERBY-1643
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.2.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY1643_diff_V1_RevokeExecutePrivilege.txt, 
> DERBY1643_stat_V1_RevokeExecutePrivilege.txt
>
>
> As per the functional spec attached to DERBY-1330, a "revoke execute ... 
> restrict" should fail if there are dependent objects on the execute privilege
> In order to implement this, when revoke execute is executed, a special 
> invalidation action should be sent and dependent objects will need to catch 
> that invalidation and throw an exception. If there are no dependents, then no 
> exception will be thrown and revoke execute will succeed.
> I am just creating a new jira entry here so it is easier to track sub items 
> of DERBY-1330. Will link this Jira entry to DERBY-1330. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to