[ 
http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12426832 ] 
            
Andrew McIntyre commented on DERBY-1547:
----------------------------------------

I think this is as simple as:

Index: java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
===================================================================
--- java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java   
(revision 429937)
+++ java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java   
(working copy)
@@ -283,7 +283,7 @@
        public String getDatabaseProductVersion() {
                ProductVersionHolder myPVH = 
Monitor.getMonitor().getEngineVersion();
 
-               return myPVH.getVersionBuildString(false);
+               return myPVH.getVersionBuildString(true);
        }
 
     /**

as well as updating metadata_test.java to not chomp the build string returned 
from getDatabaseProductVersion() and then updating the appropriate test 
masters. I'd love to assign myself to this and fix it, but I feel I may already 
be overcommitted to 10.2 issues at this point. Hopefully someone else can pick 
this up and carry it to completion.

> Add svn version  number to DatabaseMetaData getDatabaseProductVersion and 
> getDriverVersion()  to improve supportability
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1547
>                 URL: http://issues.apache.org/jira/browse/DERBY-1547
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.1.3.2
>            Reporter: Kathey Marsden
>            Priority: Minor
>             Fix For: 10.2.0.0
>
>
> getDatabaseProductVersion and getDriverVersion() report only the four digit 
> Derby version number and not the svn build number.   It would be useful to 
> return  the full version including the build number  as sysinfo does: e.g. 
> "10.1.2.4 - (392472)", That way it will be clear from application logs that 
> collect this information exactly what revision level they are running if they 
> are using rolled up fixes on the maintenance branch between releases.
> There may be risk in doing this however if applications are parsing the 
> version information, but hopefully they will use getDatabaseMajorVersion() , 
> getDatbaseMinorVersion, getDriverMajorVersion, and getDriverMinorVersion for 
> such proccessing.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to