Kathey Marsden wrote:

Do we need a formal vote?

I think that we should probably have a formal vote now on the wording and at least get formal +1 votes from a few committers. If later there are changes to the code that make the note about the existing code not necessary, then that code change can go through the normal code submission channels and that wording removed without controversy or vote I think. The vote text will look like this:

Subject : [VOTE]  Approve coding conventions for the Derby project

This is a vote to define the coding conventions for the Derby project per the db project guidelines http://db.apache.org/source.html

Derby uses the "Code Conventions for the Java Programming Language" (http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html) with space indentation (no tabs). One variation is that Derby does not discourage deferring variable declaration to the first use. Lines should be limited to 80 characters and @author tags should not be used at all. Note: There is a great deal of existing code that does not match this convention. Changes to existing code should match the surrounding code for readability, matching tabs or spaces as appropriate (see Tabs) . Patches should not have white space diffs. Code and diffs should be readable in context.

[+1]  Adopt the coding convention described.
[-1 ] Do not adopt the coding convention described.

Any objections to the content or wording that need further discussion?
Any objections to starting a vote tomorrow morning and closing Tuesday 4pm PST?
I'll post for vote tomorrow if I don't hear anything.

Kathey


Reply via email to