[ http://issues.apache.org/jira/browse/DERBY-1688?page=comments#action_12427917 ] Dag H. Wanvik commented on DERBY-1688: --------------------------------------
Looks good. Since this code is/could be non-obvious, I think it would be nice to add a code comment including a link to the URL you mention. > ConsistencyToken.hashCode() is not thread safe > ---------------------------------------------- > > Key: DERBY-1688 > URL: http://issues.apache.org/jira/browse/DERBY-1688 > Project: Derby > Issue Type: Bug > Components: Network Server > Affects Versions: 10.2.0.0, 10.3.0.0, 10.2.2.0 > Reporter: Knut Anders Hatlen > Assigned To: Knut Anders Hatlen > Priority: Minor > Attachments: derby-1688.diff, derby-1688.stat > > > If ConsistencyToken.hashCode() is run concurrently by different threads, some > of the threads may see a partial result instead of the correct hash code. > This is not a problem in the current code since all calls to that method are > synchronized on a higher level, but it would be good to fix in case the > method will be used differently in the future. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
