[ http://issues.apache.org/jira/browse/DERBY-1032?page=comments#action_12428264 ] Bryan Pendleton commented on DERBY-1032: ----------------------------------------
derby-1032-addtodist2.diff looks fine to me. > Create new scripts which follow common practice at Apache > --------------------------------------------------------- > > Key: DERBY-1032 > URL: http://issues.apache.org/jira/browse/DERBY-1032 > Project: Derby > Issue Type: Improvement > Components: Demos/Scripts > Affects Versions: 10.2.0.0 > Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Priority: Minor > Fix For: 10.2.0.0 > > Attachments: derby-1032-addtodist.diff, derby-1032-addtodist2.diff, > derby-1032-bin-sh.tgz, derby-1032-v1.diff, derby-1032-v2.diff > > > Scripts for Derby should be written to follow common practice at Apache. This > means locating them in a bin directory, and self configuring from the minimum > amount of information necessary: installation location and in our case, the > location of Java, from the variables DERBY_HOME and JAVA_HOME respectively. > If these variables are not set, we should report this to the user. Good > examples are available in Ant, Forrest, and Maven, and much of the same setup > code can be reused from those projects. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
