The functional tests would continue to live in their current location,
just that the super-class BaseJDBCTestCase would be in the new package.

Thoughts?

I support moving the utility classes to a new package.

Below are some thoughts on how Junit tests could be structured, in case
we would like to also move tests:

Package for derby-specific utility classes:

org.apache.derbyTesting.junit.util
 -> TestConfiguration, JDBCClient, JDBC,..


Package for common testcase/testsetup classes:

org.apache.derbyTesting.junit.common
 -> BaseTestCase, BaseJDBCTestCase, BaseJDBCTestSetup

I'm not sure the split between util and common here is worth it. The
classes in common have a very close relationship with the classes in
util, to my mind it seems they should be together.


Yes, that is correct.

Packages for tests:
 org.apache.derbyTesting.junit.tests
 org.apache.derbyTesting.junit.tests.jdbcapi
 org.apache.derbyTesting.junit.tests.lang
 org.apache.derbyTesting.junit.tests.store
 org.apache.derbyTesting.junit.tests. . .


I don't see any value in this, the existing layput looks fine to me.

org.apache.derbyTesting.junit.functionalTests.tests.jdbcapi
org.apache.derbyTesting.junit.unitTests.lang
org.apache.derbyTesting.junit.systemTests.app1 (future)

(Note: existing layout does not have .junit.)

The value would have been to separate out the junit tests from the other tests, however I understand it is not prioritized and possibly not worth the effort.

Regards
Andreas

Reply via email to