[EMAIL PROTECTED] wrote:
> Author: andreask
> Date: Fri Aug 18 06:05:45 2006
> New Revision: 432569
>
> URL: http://svn.apache.org/viewvc?rev=432569&view=rev
> Log:
> Fixed bug in setUp causing it to only start server when running in embedded
> mode.
> final public class NetworkServerTestSetup extends TestSetup {
> @@ -57,7 +53,7 @@
> */
> protected void setUp() throws Exception {
>
> - if (config.getJDBCClient().isEmbedded()) {
> + if (!config.getJDBCClient().isEmbedded()) {
> BaseTestCase.println("Starting network server:");
> networkServerController = new NetworkServerControl
> (InetAddress.getByName(config.getHostName()),
> config.getPort());
>
Why is the check for isEmbedded even there?
Wouldn't a test or a suite installing this decorator indicate that the
network server needs to be started? Not saying it's wrong, I'm just
trying to understand how it would be used. I was assuming that this
decorator would only be used outside of the existing harness, or inside
the harness only for tests that only run in network server mode.
E.g. I was imanging a top level JUnit suite AllJDBC that would include
the jdbcapi._Suite and jdbc40._Suite like this.
suite.add(jdbcapi._Suite.suite());
suite.add(jdbcapi._Suite.suite());
suite.add(new NetworkServerTestSetup(jdbcapi._Suite.suite()));
suite.add(new NetworkServerTestSetup(jdbc40._Suite.suite()));
Dan.
