[ 
http://issues.apache.org/jira/browse/DERBY-1636?page=comments#action_12429157 ] 
            
Sunitha Kambhampati commented on DERBY-1636:
--------------------------------------------

Hi Laura, 

I looked at the zip files derby1636_devguide_html and derby1636_ref_html and 
here are some of my minor comments. With derby-1156 feature,  now we can 
encrypt an existing unencrypted database and encrypt an existing encrypted 
database.   I think it might be good to explicit mention , what attributes are 
needed when encrypting an unencrypted database and what is needed for 
encrypting an encrypted database..   

Thanks. 
----------------
FILE: cdevcsecure97760.html
1)Title change to explicitly say "Encrypting an existing unencrypted database" 
2)Title "Encrypting databases with a new boot password" , "Encrypting databases 
with a new external key"
I think it might be good to put these two links as sublinks to a link with 
title "Encryption an existing encrypted database" 
Then we would have something like:
Encrypting an existing database
        You can encrypt an encrypted database with a new bootPassword or 
external key.
        Encrypting databases with a new boot password
        ....
        Encrypting databases with a new external key
        ...

FILE: tdevcsecureunencrypteddb.html
3)I think this statement
"When you encrypt an existing, unencrypted database, you can specify whether 
the database is encrypted using a boot password or an encryption key." 
should be
"
When you encrypt an existing, unencrypted database, you can specify whether the 
database should be encrypted using a boot password or an encryption key."


FILE: tdevcsecurenewextkey.html
4)I think it may be better to say "To encrypt" instead of "To encrypting" in 
this line"To encrypting a database with a new external key:"

---------------
file:rrefattrib15290.html
5)Change the first line in function to explicitly say , configure an existing 
unencrypted database for encryption.
"Specifies data encryption on disk for a new database or to configure an 
existing unencrypted database for encryption."

With derby-1622 we have the encryptionKey=key doc changes. Please add that here.
The dataEncryption attribute must be combined with the bootPassword=key 
attribute or the encryptionKey=key attribute.

In the examples also, better to say explicitly that to configure an existing 
unencrypted database.
 -- configure an existing unencrypted database for encryption 

6)file:rrefattrib42100.html
Function:
Explicitly mention both in examples and in function, 
that to configure an existing unencrypted database for encryption.

Where we have 'configure an existing database for encryption' use 'configure an 
existing unencrypted database for encryption' to make it clear. 

Similarly for the other files in this zip file for reference guide. 

7)Also please change the encryptionKey=Key page also that got committed with 
1622. 
rrefattribencryptkey.html
In function, change this "Configure an existing database for encryption" to 
"Configure an existing unencrypted database for encryption"

In 'combining with other attributes', for the statement starting with "When you 
configure an existing database for encryption..". Remove the next line. I think 
there is no need to specify this specifically here about encryptionAlgorithm 
because now we are explicitly talking about unencrypted database. 

--------
FILE: rrefattribnewbootpw.html
8)Change this "Specifies a new boot password for a database. " to 
say 
"Specifies a new boot password for an encrypted database." 

FILE:file:rrefattribnewencryptkey.html
Add the word encrypted. So change this " Specifies a new external encryption 
key for a database" to 
say
"Specifies a new external encryption key for an encrypted database"
---------


> document   encryption of an un-encrypted database and re-encryption with new 
> password/key.
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1636
>                 URL: http://issues.apache.org/jira/browse/DERBY-1636
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.2.1.0
>            Reporter: Suresh Thalamati
>         Assigned To: Laura Stewart
>             Fix For: 10.2.1.0
>
>         Attachments: derby1636_devguide.diff, derby1636_devguide_html.zip, 
> derby1636_ref.diff, derby1636_ref_html.zip, reencrypt_devgudechanges.txt, 
> reencryptspec_1.html
>
>
> document   encryption of an un-encrypted database and re-encryption with new 
> password/key. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to